Re: [PATCH V1 1/2] mailbox: tegra: hsp: add noirq resume

[Thierry Reding]

On Fri, Jun 14, 2019 at 05:35:33AM -0700, Bitan Biswas wrote:
> Add noirq resume instead of resume callback for Tegra HSP. Tegra HSP
> resume needs tegra_hsp_doorbell_startup() call to fix timeout error for
> tegra_bpmp_transfer() during genpd resume noirq on jetson-tx2.

s/jetson-tx2/Jetson TX2/?

> 
> Signed-off-by: Bitan Biswas <bbiswas@xxxxxxxxxx>
> ---
>  drivers/mailbox/tegra-hsp.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
> index 91f1a0c..f147374 100644
> --- a/drivers/mailbox/tegra-hsp.c
> +++ b/drivers/mailbox/tegra-hsp.c
> @@ -771,10 +771,16 @@ static int tegra_hsp_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int __maybe_unused tegra_hsp_resume(struct device *dev)
> +static int __maybe_unused tegra_hsp_noirq_resume(struct device *dev)

Maybe call this tegra_hsp_resume_noirq() to match the naming of the
dev_pm_ops callback?

>  {
>  	struct tegra_hsp *hsp = dev_get_drvdata(dev);
>  	unsigned int i;
> +	struct tegra_hsp_doorbell *db;
> +
> +	list_for_each_entry(db, &hsp->doorbells, list) {
> +		if (db && db->channel.chan)
> +			tegra_hsp_doorbell_startup(db->channel.chan);
> +	}
>  
>  	for (i = 0; i < hsp->num_sm; i++) {
>  		struct tegra_hsp_mailbox *mb = &hsp->mailboxes[i];
> @@ -786,7 +792,9 @@ static int __maybe_unused tegra_hsp_resume(struct device *dev)
>  	return 0;
>  }
>  
> -static SIMPLE_DEV_PM_OPS(tegra_hsp_pm_ops, NULL, tegra_hsp_resume);
> +static const struct dev_pm_ops tegra_hsp_pm_ops = {
> +	.resume_noirq   = tegra_hsp_noirq_resume,

There seems to be two extra spaces before that =.

Thierry

Attachment: signature.asc
Description: PGP signature