Re: [PATCH v2 4/5] x86/bpf: Fix 64-bit JIT frame pointer usage
From: Josh Poimboeuf
Date: Fri Jun 14 2019 - 17:24:15 EST
On Fri, Jun 14, 2019 at 02:05:56PM -0700, Alexei Starovoitov wrote:
> Have you tested it ?
> I really doubt, since in my test both CONFIG_UNWINDER_ORC and
> CONFIG_UNWINDER_FRAME_POINTER failed to unwind through such odd frame.
Hm, are you seeing selftest failures? They seem to work for me.
> Here is much simple patch that I mentioned in the email yesterday,
> but you failed to listen instead of focusing on perceived 'code readability'.
>
> It makes one proper frame and both frame and orc unwinders are happy.
I'm on my way out the door and I just skimmed it, but it looks fine.
Some of the code and patch description look familiar, please be sure to
give me proper credit.
--
Josh