Re: [PATCH v2 4/5] x86/bpf: Fix 64-bit JIT frame pointer usage

From: Josh Poimboeuf
Date: Sat Jun 15 2019 - 00:32:48 EST


On Fri, Jun 14, 2019 at 05:02:36PM -0700, Alexei Starovoitov wrote:
> On Fri, Jun 14, 2019 at 4:54 PM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > The previous patch you posted has my patch description, push/pop and
> > comment changes, with no credit:
> >
> > https://lkml.kernel.org/r/20190614210555.q4ictql3tzzjio4r@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
> I'm sorry for reusing one sentence from your commit log and
> not realizing you want credit for that.
> Will not happen again.

Um. What are you talking about? The entire patch was clearly derived
from mine. Not just "one sentence from your commit log". The title,
the pushes/pops in the prologue/epilogue, the removal of the
"ebpf_from_cbpf" argument, the code spacing, and some of the non trivial
comment changes were the same.

> I also suggest you never touch anything bpf related.
> Just to avoid this credit claims and threads like this one.

Wth. I made a simple request for credit. Anybody can see the patch was
derived from mine. It's not like I really care. It's just basic human
decency.

--
Josh