RE: [PATCH net] hvsock: fix epollout hang from race condition

[Dexuan Cui]

> From: linux-hyperv-owner@xxxxxxxxxxxxxxx
> <linux-hyperv-owner@xxxxxxxxxxxxxxx> On Behalf Of Dexuan Cui
> Sent: Friday, June 14, 2019 8:23 PM
> To: David Miller <davem@xxxxxxxxxxxxx>; Sunil Muthuswamy
> <sunilmut@xxxxxxxxxxxxx>
> Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>; sashal@xxxxxxxxxx; Michael Kelley
> <mikelley@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-hyperv@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH net] hvsock: fix epollout hang from race condition
> 
> > From: linux-hyperv-owner@xxxxxxxxxxxxxxx
> > <linux-hyperv-owner@xxxxxxxxxxxxxxx> On Behalf Of David Miller
> > Sent: Friday, June 14, 2019 7:15 PM
> > To: Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>
> >
> > This adds lots of new warnings:
> >
> > net/vmw_vsock/hyperv_transport.c: In function ʽhvs_probeʼ:
> > net/vmw_vsock/hyperv_transport.c:205:20: warning: ʽvnewʼ may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
> >    remote->svm_port = host_ephemeral_port++;
> >    ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
> > net/vmw_vsock/hyperv_transport.c:332:21: note: ʽvnewʼ was declared
> here
> >   struct vsock_sock *vnew;
> >                      ^~~~
> > net/vmw_vsock/hyperv_transport.c:406:22: warning: ʽhvs_newʼ may be
> > used uninitialized in this function [-Wmaybe-uninitialized]
> >    hvs_new->vm_srv_id = *if_type;
> >    ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
> > net/vmw_vsock/hyperv_transport.c:333:23: note: ʽhvs_newʼ was declared
> > here
> >   struct hvsock *hvs, *hvs_new;
> >                        ^~~~~~~
> 
> Hi David,
> These warnings are not introduced by this patch from Sunil.

Well, technically speaking, the warnings are caused by Suni's patch, but I think it should
be a bug of gcc (I'm using "gcc (Ubuntu 8.2.0-12ubuntu1) 8.2.0"). As you can see, the
line numbers given by gcc, i.e. line 205, line 406, are not related to the warnings.

Actually, the same warnings can repro with the below one-line patch on this commit of
today's net.git:
    9a33629ba6b2 ("hv_netvsc: Set probe mode to sync")

--- a/net/vmw_vsock/hyperv_transport.c
+++ b/net/vmw_vsock/hyperv_transport.c
@@ -403,6 +403,7 @@ static void hvs_open_connection(struct vmbus_channel *chan)

        set_per_channel_state(chan, conn_from_host ? new : sk);
        vmbus_set_chn_rescind_callback(chan, hvs_close_connection);
+       asm ("nop");

        if (conn_from_host) {
                new->sk_state = TCP_ESTABLISHED;

It looks a simple inline assembly code can confuse gcc. I'm not sure if I should
report a bug for gcc...

I posted a patch to suppress these bogus warnings just now. The Subject is:

[PATCH net] hv_sock: Suppress bogus "may be used uninitialized" warnings

Thanks,
-- Dexuan