Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state

From: Alistair Popple
Date: Sun Jun 16 2019 - 22:13:31 EST


This fixed the problem I was having trying to issue istep operations to the
SBE.

Tested-by: Alistair Popple <alistair@xxxxxxxxxxxx>

On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> SBE fifo operations should be allowed while the SBE is in any of the
> "IPL" states. Operations should succeed in this state.
>
> Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
> ---
> drivers/fsi/fsi-sbefifo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index c7d13ac..f7665b3 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
> return -ESHUTDOWN;
> + case SBE_STATE_DMT:
> + return -EBUSY;
> case SBE_STATE_IPLING:
> case SBE_STATE_ISTEP:
> case SBE_STATE_MPIPL:
> - case SBE_STATE_DMT:
> - return -EBUSY;
> case SBE_STATE_RUNTIME:
> case SBE_STATE_DUMP: /* Not sure about that one */
> break;