Re: [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases

From: Fabrice Gasnier
Date: Mon Jun 17 2019 - 03:59:37 EST


On 6/14/19 10:53 PM, Wolfram Sang wrote:
> Hi Fabrice,
>
>> + return irq_event ? irq_event : -ENODEV;
>
> Maybe -ENOENT instead of -ENODEV? I mean you have a dev_err there, so
> the driver core should probably also complain?
>
> You could also shorten the ternary operator to:
>
> return irq_event ? : -E<whatyouprefer>;
>
> However, both are minor nits. If you prefer to keep the patch as is,
> fine with me.

Hi Wolfram,

Thanks for reviewing,
I've sent a v3 with your suggestions.

Regards,
Fabrice
>
> Regards,
>
> Wolfram
>