Re: [PATCH] Use fall-through attribute rather than magic comments

[Pavel Machek]

Hi!

> +/*
> + *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough
> + *   gcc: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
> + */
> +#if __has_attribute(__fallthrough__)
> +# define __fallthrough                    __attribute__((__fallthrough__))
> +#else
> +# define __fallthrough
> +#endif

Is it good idea to add the __'s ? They look kind of ugly. 
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature