Re: [PATCH] bpf: hide do_bpf_send_signal when unused

From: Steven Rostedt
Date: Mon Jun 17 2019 - 20:23:53 EST


On Mon, 17 Jun 2019 16:27:33 -0700
Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote:

> On Mon, Jun 17, 2019 at 4:13 PM Matt Mullins <mmullins@xxxxxx> wrote:
> > >
> > > The bug (really just a warning) reported is exactly here.
> >
> > I don't think bpf_send_signal is tied to modules at all;
> > send_signal_irq_work_init and the corresponding initcall should be
> > moved outside that #ifdef.
>
> right. I guess send_signal_irq_work_init was accidentally placed
> after bpf_event_init and happened to be within that ifdef.
> Should definitely be outside.

So Arnd did find a bug. Just the wrong solution ;-)

-- Steve