Re: [PATCH RESEND] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem

From: Christoph Hellwig
Date: Tue Jun 18 2019 - 03:04:23 EST

Next message: Richard Weinberger: "Re: [PATCH v2] jffs2: remove C++ style comments from uapi header"
Previous message: Adrian Hunter: "Re: [PATCH v2 2/3] mmc: sdhci: sdhci-pci-o2micro: Check if controller supports 8-bit width"
In reply to: Puranjay Mohan: "[PATCH RESEND] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> -#define CRAMFS_BLK_FLAG_UNCOMPRESSED (1 << 31)
> +#define CRAMFS_BLK_FLAG_UNCOMPRESSED (1U << 31)
> #define CRAMFS_BLK_FLAG_DIRECT_PTR (1 << 30)

Please use the unsigned constants for all flags, not just one.

Next message: Richard Weinberger: "Re: [PATCH v2] jffs2: remove C++ style comments from uapi header"
Previous message: Adrian Hunter: "Re: [PATCH v2 2/3] mmc: sdhci: sdhci-pci-o2micro: Check if controller supports 8-bit width"
In reply to: Puranjay Mohan: "[PATCH RESEND] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]