Re: [PATCH] tty: serial_core: recover uport->cons->cflag on uart_close

From: Greg KH
Date: Tue Jun 18 2019 - 03:56:34 EST

On Sun, Jun 16, 2019 at 06:57:14PM +0400, kpark3469@xxxxxxxxx wrote:
> From: Sahara <keun-o.park@xxxxxxxxxxxxx>

I need a "full" name here please, something you use to sign legal

> Since uart_close was converted to use tty_port_close, uart_shutdown
> also moved to uart_tty_port_shutdown, which means it does not backup
> tty's termios to uart_port.console.cflag when console is closed and
> uart_console is true.
> By losing this value, serial console was not set correctly especially
> after suspend/resume when there is no consumer of console device.
> This problem resets console driver's configuration to an unwanted value
> and may give a performance regression in the system eventually.
> This patch fixes the bug introduced from v4.9 kernel.
> Fixes: 761ed4a94582 ("tty: serial_core: convert uart_close to use tty_port_close")
> Reported-by: Jouni Linnamaa <Jouni.Linnamaa@xxxxxxxxxxxxx>
> Signed-off-by: Sahara <keun-o.park@xxxxxxxxxxxxx>

Same here as well.


greg k-h