Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU

[Christophe Leroy]

Le 18/06/2019 Ã 14:31, Michael Ellerman a ÃcritÂ:
> Christophe Leroy <christophe.leroy@xxxxxx> writes:
> > Le 11/06/2019 Ã 17:47, Christophe Leroy a ÃcritÂ:
> > > The patch referenced below moved the loading of segment registers
> > > out of load_up_mmu() in order to do it earlier in the boot sequence.
> > > However, the secondary CPU still needs it to be done when loading up
> > > the MMU.
> > >
> > > Reported-by: Erhard F. <erhard_f@xxxxxxxxxxx>
> > > Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN")
> >
> > Cc: stable@xxxxxxxxxxxxxxx
>
> Sorry patchwork didn't pick that up and I missed it. The AUTOSEL bot
> will probably pick it up anyway though.

Don't worry, this was unneeded because we added KASAN in 5.2.
My mistake.
Christophe

> cheers
>
> > > diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
> > > index 1d5f1bd0dacd..f255e22184b4 100644
> > > --- a/arch/powerpc/kernel/head_32.S
> > > +++ b/arch/powerpc/kernel/head_32.S
> > > @@ -752,6 +752,7 @@ __secondary_start:
> > >    	stw	r0,0(r3)
> > >    
> > >    	/* load up the MMU */
> > > +	bl	load_segment_registers
> > >    	bl	load_up_mmu
> > >    
> > >    	/* ptr to phys current thread */