Re: [PATCH v2 2/2] crypto: testmgr - dynamically allocate crypto_shash
From: Eric Biggers
Date: Tue Jun 18 2019 - 14:12:56 EST
On Tue, Jun 18, 2019 at 11:21:53AM +0200, Arnd Bergmann wrote:
> The largest stack object in this file is now the shash descriptor.
> Since there are many other stack variables, this can push it
> over the 1024 byte warning limit, in particular with clang and
> crypto/testmgr.c:1693:12: error: stack frame size of 1312 bytes in function '__alg_test_hash' [-Werror,-Wframe-larger-than=]
> Make test_hash_vs_generic_impl() do the same thing as the
> corresponding eaed and skcipher functions by allocating the
Typo: "eaed" should be "aead"
> descriptor dynamically. We can still do better than this,
> but it brings us well below the 1024 byte limit.
> Suggested-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> Fixes: 9a8a6b3f0950 ("crypto: testmgr - fuzz hashes against their generic implementation")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Actual patch looks fine though. Thanks!
Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>