Re: [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc

From: Saeed Mahameed
Date: Tue Jun 18 2019 - 15:08:06 EST


On Tue, 2019-06-18 at 16:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Function mlx5_devlink_alloc is missing a void argument, add it
> to clean up the non-ANSI function declaration.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index ed4202e883f0..1533c657220b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -37,7 +37,7 @@ static const struct devlink_ops mlx5_devlink_ops =
> {
> .flash_update = mlx5_devlink_flash_update,
> };
>
> -struct devlink *mlx5_devlink_alloc()
> +struct devlink *mlx5_devlink_alloc(void)
> {
> return devlink_alloc(&mlx5_devlink_ops, sizeof(struct
> mlx5_core_dev));
> }

Acked-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx>

Dave, this one can go to net-next.

Thanks,
Saeed.