Re: [PATCH 1/2] mfd: mt6397: Use PLATFORM_DEVID_NONE macro instead of -1

From: Matthias Brugger
Date: Tue Jun 18 2019 - 17:21:11 EST




On 18/06/2019 17:43, Fabien Parent wrote:
> Use the correct macro when adding the MFD devices instead of using
> directly '-1' value.
>
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>

Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>

> ---
> drivers/mfd/mt6397-core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 337bcccdb914..190ed86ad93e 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -299,9 +299,9 @@ static int mt6397_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - ret = devm_mfd_add_devices(&pdev->dev, -1, mt6323_devs,
> - ARRAY_SIZE(mt6323_devs), NULL,
> - 0, pmic->irq_domain);
> + ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> + mt6323_devs, ARRAY_SIZE(mt6323_devs),
> + NULL, 0, pmic->irq_domain);
> break;
>
> case MT6397_CID_CODE:
> @@ -314,9 +314,9 @@ static int mt6397_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - ret = devm_mfd_add_devices(&pdev->dev, -1, mt6397_devs,
> - ARRAY_SIZE(mt6397_devs), NULL,
> - 0, pmic->irq_domain);
> + ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> + mt6397_devs, ARRAY_SIZE(mt6397_devs),
> + NULL, 0, pmic->irq_domain);
> break;
>
> default:
>