Re: [PATCH RFC 2/3] fonts: Use BUILD_BUG_ON() for checking empty font table

From: Randy Dunlap
Date: Tue Jun 18 2019 - 19:11:10 EST


On 6/18/19 1:34 PM, Takashi Iwai wrote:
> We have a nice macro, and the check of emptiness of the font table can
> be done in a simpler way.
>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Hi,

Looks good to me.
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Also, would you mind adding TER16x32 to Documentation/fb/fbcon.rst, here:
(AFAIK that would be appropriate.)

1. fbcon=font:<name>

Select the initial font to use. The value 'name' can be any of the
compiled-in fonts: 10x18, 6x10, 7x14, Acorn8x8, MINI4x6,
PEARL8x8, ProFont6x11, SUN12x22, SUN8x16, VGA8x16, VGA8x8.

> ---
> lib/fonts/fonts.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)

Thanks.
--
~Randy