Re: [PATCH v3 -next] firmware: ti_sci: Fix gcc unused-but-set-variable warning

From: santosh.shilimkar@xxxxxxxxxx
Date: Wed Jun 19 2019 - 00:41:04 EST


On 6/17/19 11:41 AM, Suman Anna wrote:
On 6/15/19 7:50 AM, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config:
drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_get_config:
drivers/firmware/ti_sci.c:2104:17: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_tx_ch_cfg:
drivers/firmware/ti_sci.c:2287:17: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_rx_ch_cfg:
drivers/firmware/ti_sci.c:2357:17: warning: variable dev set but not used [-Wunused-but-set-variable]

Use the 'dev' variable instead of info->dev to fix this.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Acked-by: Suman Anna <s-anna@xxxxxx>

Hi Santosh,
Can you pick up this patch, goes on top of your for_5.3/driver-soc branch?

Applied.