Re: [PATCH] mailbox: tegra-hsp: mark PM functions as __maybe_unused

From: Anders Roxell
Date: Wed Jun 19 2019 - 04:03:09 EST


On Wed, 19 Jun 2019 at 09:56, Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:
>
> On Thu, 10 Jan 2019 at 09:16, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> >
> > On Tue, Jan 08, 2019 at 03:37:13PM +0100, Anders Roxell wrote:
> > > Without CONFIG_PM_SLEEP, we get annoying warnings about unused
> > > functions:
> > >
> > > drivers/mailbox/tegra-hsp.c:782:12: warning: âtegra_hsp_resumeâ defined but not used [-Wunused-function]
> > > static int tegra_hsp_resume(struct device *dev)
> > > ^~~~~~~~~~~~~~~~
> > >
> > > Mark them as __maybe_unused to shut up the warning and silently drop the
> > > functions without having to add ugly #ifdefs.
> > >
> > > Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")
> > > Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> > > ---
> > > drivers/mailbox/tegra-hsp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Acked-by: Thierry Reding <treding@xxxxxxxxxx>
>
> Will this be picked up ?

its already solved.

Sorry for the noice. =/

Anders

>
> Cheers,
> Anders