Re: [PATCH v2] sched/core: clean up sched_init() a bit

[Qian Cai]

Ping.

On Tue, 2019-06-04 at 16:46 -0400, Qian Cai wrote:
> Compiling a kernel with both FAIR_GROUP_SCHED=n and RT_GROUP_SCHED=n
> will generate a warning using W=1:
> 
> Â kernel/sched/core.c: In function 'sched_init':
> Â kernel/sched/core.c:5906:32: warning: variable 'ptr' set but not used
> 
> Use this opportunity to tidy up a code a bit by removing unnecssary
> indentations, #endif comments and lines.
> 
> Signed-off-by: Qian Cai <cai@xxxxxx>
> ---
> 
> v2: Fix an oversight when both FAIR_GROUP_SCHED and RT_GROUP_SCHED
> ÂÂÂÂselected which was found by the 0day kernel testing robot.
> 
> Âkernel/sched/core.c | 50 +++++++++++++++++++++++---------------------------
> Â1 file changed, 23 insertions(+), 27 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 874c427742a9..edebd5e97542 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5903,36 +5903,31 @@ int in_sched_functions(unsigned long addr)
> Âvoid __init sched_init(void)
> Â{
> Â	int i, j;
> -	unsigned long alloc_size = 0, ptr;
> -
> -	wait_bit_init();
> -
> -#ifdef CONFIG_FAIR_GROUP_SCHED
> -	alloc_size += 2 * nr_cpu_ids * sizeof(void **);
> +#if defined(CONFIG_FAIR_GROUP_SCHED) && defined(CONFIG_RT_GROUP_SCHED)
> +	unsigned long alloc_size = 4 * nr_cpu_ids * sizeof(void **);
> +	unsigned long ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
> +#elif defined(CONFIG_FAIR_GROUP_SCHED) || defined(CONFIG_RT_GROUP_SCHED)
> +	unsigned long alloc_size = 2 * nr_cpu_ids * sizeof(void **);
> +	unsigned long ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
> Â#endif
> -#ifdef CONFIG_RT_GROUP_SCHED
> -	alloc_size += 2 * nr_cpu_ids * sizeof(void **);
> -#endif
> -	if (alloc_size) {
> -		ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
> +	wait_bit_init();
> Â
> Â#ifdef CONFIG_FAIR_GROUP_SCHED
> -		root_task_group.se = (struct sched_entity **)ptr;
> -		ptr += nr_cpu_ids * sizeof(void **);
> +	root_task_group.se = (struct sched_entity **)ptr;
> +	ptr += nr_cpu_ids * sizeof(void **);
> Â
> -		root_task_group.cfs_rq = (struct cfs_rq **)ptr;
> -		ptr += nr_cpu_ids * sizeof(void **);
> +	root_task_group.cfs_rq = (struct cfs_rq **)ptr;
> +	ptr += nr_cpu_ids * sizeof(void **);
> Â
> -#endif /* CONFIG_FAIR_GROUP_SCHED */
> +#endif
> Â#ifdef CONFIG_RT_GROUP_SCHED
> -		root_task_group.rt_se = (struct sched_rt_entity **)ptr;
> -		ptr += nr_cpu_ids * sizeof(void **);
> +	root_task_group.rt_se = (struct sched_rt_entity **)ptr;
> +	ptr += nr_cpu_ids * sizeof(void **);
> Â
> -		root_task_group.rt_rq = (struct rt_rq **)ptr;
> -		ptr += nr_cpu_ids * sizeof(void **);
> +	root_task_group.rt_rq = (struct rt_rq **)ptr;
> +	ptr += nr_cpu_ids * sizeof(void **);
> Â
> -#endif /* CONFIG_RT_GROUP_SCHED */
> -	}
> +#endif
> Â#ifdef CONFIG_CPUMASK_OFFSTACK
> Â	for_each_possible_cpu(i) {
> Â		per_cpu(load_balance_mask, i) = (cpumask_var_t)kzalloc_node(
> @@ -5940,7 +5935,7 @@ void __init sched_init(void)
> Â		per_cpu(select_idle_mask, i) = (cpumask_var_t)kzalloc_node(
> Â			cpumask_size(), GFP_KERNEL, cpu_to_node(i));
> Â	}
> -#endif /* CONFIG_CPUMASK_OFFSTACK */
> +#endif
> Â
> Â	init_rt_bandwidth(&def_rt_bandwidth, global_rt_period(),
> global_rt_runtime());
> Â	init_dl_bandwidth(&def_dl_bandwidth, global_rt_period(),
> global_rt_runtime());
> @@ -5950,9 +5945,9 @@ void __init sched_init(void)
> Â#endif
> Â
> Â#ifdef CONFIG_RT_GROUP_SCHED
> -	init_rt_bandwidth(&root_task_group.rt_bandwidth,
> -			global_rt_period(), global_rt_runtime());
> -#endif /* CONFIG_RT_GROUP_SCHED */
> +	init_rt_bandwidth(&root_task_group.rt_bandwidth, global_rt_period(),
> +			ÂÂglobal_rt_runtime());
> +#endif
> Â
> Â#ifdef CONFIG_CGROUP_SCHED
> Â	task_group_cache = KMEM_CACHE(task_group, 0);
> @@ -5961,7 +5956,7 @@ void __init sched_init(void)
> Â	INIT_LIST_HEAD(&root_task_group.children);
> Â	INIT_LIST_HEAD(&root_task_group.siblings);
> Â	autogroup_init(&init_task);
> -#endif /* CONFIG_CGROUP_SCHED */
> +#endif
> Â
> Â	for_each_possible_cpu(i) {
> Â		struct rq *rq;
> @@ -6031,6 +6026,7 @@ void __init sched_init(void)
> Â		rq->last_blocked_load_update_tick = jiffies;
> Â		atomic_set(&rq->nohz_flags, 0);
> Â#endif
> +
> Â#endif /* CONFIG_SMP */
> Â		hrtick_rq_init(rq);
> Â		atomic_set(&rq->nr_iowait, 0);