Re: [PATCH 2/6] dt-bindings: qcom: Add ipq6018 bindings

From: Rob Herring
Date: Wed Jun 19 2019 - 11:00:02 EST


On Wed, Jun 5, 2019 at 11:16 AM Sricharan R <sricharan@xxxxxxxxxxxxxx> wrote:
>
> Signed-off-by: Sricharan R <sricharan@xxxxxxxxxxxxxx>
> Signed-off-by: speriaka <speriaka@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index f6316ab..7b19028 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -36,6 +36,7 @@ description: |
> mdm9615
> ipq8074
> sdm845
> + ipq6018

You need to add actual schema for this, not just a description.

>
> The 'board' element must be one of the following strings:
>
> @@ -45,6 +46,7 @@ description: |
> mtp
> sbc
> hk01
> + cp01-c1
>
> The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
> where the minor number may be omitted when it's zero, i.e. v1.0 is the same
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>