Re: [PATCH 1/2] auxdisplay/cfag12864bfb.c: Convert to use vm_map_pages_zero()

From: Miguel Ojeda
Date: Thu Jun 20 2019 - 09:16:08 EST


On Sun, May 26, 2019 at 6:05 PM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>
> While using mmap, the incorrect values of length and vm_pgoff are
> ignored and this driver goes ahead with mapping cfag12864b_buffer
> to user vma.
>
> Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
> "fix" these drivers to behave according to the normal vm_pgoff
> offsetting simply by removing the _zero suffix on the function name and
> if that causes regressions, it gives us an easy way to revert.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> ---
> v2: Fixed minor typo.

Almost forgot about these two -- picking both v2s for a PR later. Not
sure what happened with the mm/ related one I sent, is it in Andrew's
tree?

Cheers,
Miguel