Re: [PATCH v2 6/6] drivers/base/memory.c: Get rid of find_memory_block_hinted()

From: David Hildenbrand
Date: Thu Jun 20 2019 - 14:25:46 EST


On 20.06.19 12:35, David Hildenbrand wrote:
> No longer needed, let's remove it. Also, drop the "hint" parameter
> completely from "find_memory_block_by_id", as nobody needs it anymore.
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Cc: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
> Cc: "mike.travis@xxxxxxx" <mike.travis@xxxxxxx>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
> drivers/base/memory.c | 32 ++++++++++----------------------
> include/linux/memory.h | 2 --
> 2 files changed, 10 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 0204384b4d1d..fefb64d3588e 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -592,26 +592,12 @@ int __weak arch_get_memory_phys_device(unsigned long start_pfn)
> * A reference for the returned object is held and the reference for the
> * hinted object is released.
> */

I'll fixup this comment as well (yes, I desperately need vacation :) )


--

Thanks,

David / dhildenb