Re: [PATCH 1/2] coresight: Set affinity to invalid for missing CPU phandle

[Sai Prakash Ranjan]

Hi Mathieu,

Thanks for the review comments.

On 6/20/2019 11:09 PM, Mathieu Poirier wrote:
> Hi Sai,
>
> On Thu, Jun 20, 2019 at 07:15:46PM +0530, Sai Prakash Ranjan wrote:
> > Affinity defaults to CPU0 in case of missing CPU phandle
> > and this leads to crashes in some cases because of such
> > wrong assumption. Fix this by returning -ENODEV in
> > coresight platform for such cases and then handle it
> > in the coresight drivers.
> >
> > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx>
> > ---
> >   drivers/hwtracing/coresight/coresight-platform.c | 10 ++++++----
> >   1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> > index 3c5ceda8db24..b1ea60c210e1 100644
> > --- a/drivers/hwtracing/coresight/coresight-platform.c
> > +++ b/drivers/hwtracing/coresight/coresight-platform.c
> > @@ -160,15 +160,17 @@ static int of_coresight_get_cpu(struct device *dev)
> >   
> >   	if (!dev->of_node)
> >   		return 0;
>
> An error should be returned if the above condition is true.

Will do it, thanks.

> > +
>
> Spurious newline

This was on purpose, the code looks much cleaner.

-Sai

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation