Re: [PATCH v7 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller

From: Sergei Shtylyov
Date: Thu Jun 20 2019 - 15:48:09 EST


On 06/20/2019 08:22 PM, Vignesh Raghavendra wrote:

> Add binding documentation for TI's HyperBus memory controller present on
> AM654 SoC.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> ---
>
> v7: Fix example to move HyperBus node out of syscon
> v6: Use generic names for bindings
>
> .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 52 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
> new file mode 100644
> index 000000000000..d424a0b88ab6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
[...]
> +Example:
> +
> + system-controller@47000000 {
> + compatible = "syscon", "simple-mfd";
> + reg = <0x0 0x47000000 0x0 0x100>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + hbmc_mux: multiplexer {
> + compatible = "mmio-mux";
> + #mux-control-cells = <1>;
> + mux-reg-masks = <0x4 0x2>; /* 0: reg 0x4, bit 1 */
> + };
> +

Empty line not needed here.

> + };
> +
> + hbmc: hyperbus@47034000 {
> + compatible = "ti,am654-hbmc";
> + reg = <0x0 0x47034000 0x0 0x100>,
> + <0x5 0x00000000 0x1 0x0000000>;
> + power-domains = <&k3_pds 55>;
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x5 0x00000000 0x4000000>, /* CS0 - 64MB */
> + <0x1 0x0 0x5 0x04000000 0x4000000>; /* CS1 - 64MB */
> + mux-controls = <&hbmc_mux 0>;
> +
> + /* Slave flash node */

Overindented.

> + flash@0,0 {
> + compatible = "cypress,hyperflash", "cfi-flash";
> + reg = <0x0 0x0 0x4000000>;
> + };
> + };
[...]

MBR, Sergei