Re: Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls

From: Markus Elfring
Date: Fri Jun 21 2019 - 05:37:58 EST


> I still don't see the point of specifying return. Why not just S, where S
> is a statement metavariable?

Do you find the following SmPL change specification more appropriate?

@deletion depends on patch@
expression e;
statement s;
@@
e = devm_ioremap_resource(...);
if (IS_ERR(e))
(
-{
- dev_err(...);
s
-}
|
{
<+...
- dev_err(...);
...+>
}
)


Will any additional constraints become relevant?


>> Would this approach need a version check for the Coccinelle software?
>
> Why would that be necessary?

I guess that the application of SmPL disjunctions for if statements
can trigger development concerns.

Regards,
Markus