Re: [PATCH 1/3] timekeeping: add missing non-_ns functions for fast accessors

[Arnd Bergmann]

On Thu, Jun 20, 2019 at 4:12 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> Previously there was no analogue to get proper ktime_t versions of the
> fast variety of ktime invocations. This commit makes the interface
> uniform with the other accessors.
>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Consistent is good, not sure if there is a real use for the *_fast()
functions returning a ktime_t, but I don't mind adding them.

> +.. c:function:: ktime_t ktime_get_mono_fast_ns( void )
> +               ktime_t ktime_get_raw_fast_ns( void )
> +               ktime_t ktime_get_boottime_fast_ns( void )
> +               ktime_t ktime_get_real_fast_ns( void )
> +
>  .. c:function:: u64 ktime_get_mono_fast_ns( void )
>                 u64 ktime_get_raw_fast_ns( void )
>                 u64 ktime_get_boot_fast_ns( void )

Typo: you have the same function names listed twice here,
one of them should be ktime_get_mono_fast() instead of
ktime_get_mono_fast_ns().

Also, we might want to rename ktime_get_boot_fast_ns()
to ktime_get_boottime_fast_ns in the process. It seems there
is only a single caller.

      Arnd