Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates

[Shuah Khan]

On 6/21/19 9:20 AM, Alan Cox wrote:
> On Fri, 21 Jun 2019 15:16:04 +0530
> Puranjay Mohan <puranjay12@xxxxxxxxx> wrote:
>
> > This patch series removes the private duplicates of PCI definitions in
> > favour of generic definitions defined in pci_regs.h.
>
> Why bother ? It's an ancient obsolete card ?
>
> Do you even have one to test ?
>
> > This driver only uses some of the generic PCI definitons,
> > which are included from pci_regs.h and thier private versions
> > are removed from skfbi.h with all other private defines.
> >
> > The skfbi.h defines PCI_REV_ID and other private defines with different
> > names, these are renamed to Generic PCI names to make them
> > compatible with defines in pci_regs.h.
> >
> > All unused defines are removed from skfbi.h.
>
> I sincerely doubt anyone on the planet is using this card any more.
>
> Alan

Thanks Alan!

Stephen Hemminger is suggesting removal as well. Makes sense to me.

David!

What would you recommend the next steps are? Would like driver removed?

thanks,
-- Shuah