Re: [PATCH v5 5/5] x86/umwait: Document umwait control sysfs interfaces

From: Thomas Gleixner
Date: Sun Jun 23 2019 - 23:01:45 EST


On Mon, 24 Jun 2019, Thomas Gleixner wrote:
> On Wed, 19 Jun 2019, Fenghua Yu wrote:
> > +Description: Umwait control
> > +
> > + enable_c02: Read/write interface to control umwait C0.2 state
> > + Read returns C0.2 state status:
> > + 0: C0.2 is disabled
> > + 1: C0.2 is enabled
> > +
> > + Write 'Yy1' or [oO][nN] for on to enable C0.2 state.
>
> Write 'Yy1' ? You meant [Yy1] I assume.
>
> > + Write 'Nn0' or [oO][fF] for off to disable C0.2 state.
>
> What about avoiding all that unreadable confusion?
>
> Write 'y' or '1' or 'on' to enable C0.2 state.
> Write 'n' or '0' or 'of' to disable C0.2 state.
>
> The interface is case insensitive.

Don't try to fixup all that in a hurry.

I've already done most of it while trying to ready if for merging. If you
see the tip bot mails coming in, make sure to double check my modifications
and yell if I screwed up on the way.

Thanks,

tglx