RE: [PATCH v4 1/5] net: macb: add phylink support

[Parshuram Raju Thombare]

>From: Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx>
>On Sun, Jun 23, 2019 at 10:17:37AM +0100, Parshuram Thombare wrote:
>> +	switch (state->interface) {
>> +	case PHY_INTERFACE_MODE_GMII:
>> +	case PHY_INTERFACE_MODE_RGMII:
>> +		if (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE) {
>> +			phylink_set(mask, 1000baseT_Full);
>> +			phylink_set(mask, 1000baseX_Full);
>> +			if (!(bp->caps & MACB_CAPS_NO_GIGABIT_HALF)) {
>> +				phylink_set(mask, 1000baseT_Half);
>> +				phylink_set(mask, 1000baseT_Half);
>I think this can be cleaned up.
Ok, I will remove duplicate 1000baseT_Half

>> -	spin_lock_irqsave(&bp->lock, flags);
>> +	linkmode_and(supported, supported, mask);
>> +	linkmode_and(state->advertising, state->advertising, mask);
>You remove this blank line in the next patch, so given that this is a
>new function, you might as well clean that up in this patch.
Ok
Regards,
Parshuram Thombare