Re: [PATCH v3 3/8] staging: erofs: move per-CPU buffers implementation to utils.c

From: Chao Yu
Date: Mon Jun 24 2019 - 03:33:29 EST


On 2019/6/24 15:22, Gao Xiang wrote:
> From: Gao Xiang <gaoxiang25@xxxxxxxxxx>
>
> This patch moves per-CPU buffers to utils.c in order for
> the upcoming generic decompression framework to use it.
>
> Note that I tried to use generic per-CPU buffer or
> per-CPU page approaches to clean up further, but obvious
> performanace regression (about 2% for sequential read) was
> observed.
>
> Therefore let's leave it as it is instead, just move
> to utils.c and I'll try to dig into the root cause later.
>
> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,