Re: [PATCH 0/4] drm/bridge: dw-hdmi: Add support for HDR metadata

[Daniel Vetter]

On Mon, Jun 24, 2019 at 10:19:34AM +0200, Neil Armstrong wrote:
> Hi Daniel, Laurent, Andrzej,
> 
> On 24/06/2019 01:30, Laurent Pinchart wrote:
> > On Fri, Jun 21, 2019 at 11:01:25AM +0200, Daniel Vetter wrote:
> >> On Thu, Jun 20, 2019 at 04:40:12PM +0200, Neil Armstrong wrote:
> >>> Hi Andrzej,
> >>>
> >>> Gentle ping, could you review the dw-hdmi changes here ?
> >>
> >> btw not sure you absolutely need review from Andrzej, we're currently a
> >> bit undersupplied with bridge reviewers I think ... Better to ramp up
> >> more.
> > 
> > I try to review DRM bridge patches when possible, but dw-hdmi is a
> > special case. I was told by the supplier of an SoC datasheet that
> > contains the HDMI encoder IP core documentation that Synopsys required
> > them to route all contributions made based on that documentation through
> > Synopsys' internal legal review before publishing them. I thus decided
> > to not contribute to the driver anymore, at least for areas that require
> > access to documentation.
> 
> I'd like to propose myself as co-maintainer of the DRM bridge subsystem if
> everybody agrees, following the excellent work Laurent and Andrzej did.
> I have a very little knowledge of DSI, & other bridge drivers, but I'll do
> my best.

Yay volunteers!

Make MAINTAINERS patch to add you, cc relevant people, get acks, merge,
tag you're it :-) Ok, co-it, the point is to have teams as much as
possible.

Cheers, Daniel
> 
> For the dw-hdmi driver, we have a big roadmap including :
> - HDR (this patchset)
> - HDCP 1/2
> - YUV420, YUV422, YUV44, 10bit/12bit/16bit HDMI output
> - Enhanced audio support and ELD notification to ASoC
> ...
> 
> Having a more active maintainer/reviewer team would be needed, at least for
> the dw-hdmi bridge.
> 
> I'll also propose Jonas Karlman <jonas@xxxxxxxxx> as reviewer since he is very
> active for the multimedia support on RockChip, Allwinner and Amlogic SoCs.
> I'll also propose Jernej Skrabec@xxxxxxxx <jernej.skrabec@xxxxxxxx>, if he wants,
> as reviewer since he is very active on the Allwinner SoCs side.
> 
> Neil
> 
> > 
> >>> On 26/05/2019 23:18, Jonas Karlman wrote:
> >>>> Add support for HDR metadata using the hdr_output_metadata connector property,
> >>>> configure Dynamic Range and Mastering InfoFrame accordingly.
> >>>>
> >>>> A drm_infoframe flag is added to dw_hdmi_plat_data that platform drivers
> >>>> can use to signal when Dynamic Range and Mastering infoframes is supported.
> >>>> This flag is needed because Amlogic GXBB and GXL report same DW-HDMI version,
> >>>> and only GXL support DRM InfoFrame.
> >>>>
> >>>> The first patch add functionality to configure DRM InfoFrame based on the
> >>>> hdr_output_metadata connector property.
> >>>>
> >>>> The remaining patches sets the drm_infoframe flag on some SoCs supporting
> >>>> Dynamic Range and Mastering InfoFrame.
> >>>>
> >>>> Note that this was based on top of drm-misc-next and Neil Armstrong's
> >>>> "drm/meson: Add support for HDMI2.0 YUV420 4k60" series at [1]
> >>>>
> >>>> [1] https://patchwork.freedesktop.org/series/58725/#rev2
> >>>>
> >>>> Jonas Karlman (4):
> >>>>   drm/bridge: dw-hdmi: Add Dynamic Range and Mastering InfoFrame support
> >>>>   drm/rockchip: Enable DRM InfoFrame support on RK3328 and RK3399
> >>>>   drm/meson: Enable DRM InfoFrame support on GXL, GXM and G12A
> >>>>   drm/sun4i: Enable DRM InfoFrame support on H6
> >>>>
> >>>>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c   | 109 ++++++++++++++++++++
> >>>>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.h   |  37 +++++++
> >>>>  drivers/gpu/drm/meson/meson_dw_hdmi.c       |   5 +
> >>>>  drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c |   2 +
> >>>>  drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c       |   2 +
> >>>>  drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h       |   1 +
> >>>>  include/drm/bridge/dw_hdmi.h                |   1 +
> >>>>  7 files changed, 157 insertions(+)
> > 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch