Re: [PATCH BUGFIX IMPROVEMENT 0/7] boost throughput with synced I/O, reduce latency and fix a bandwidth bug

From: Srivatsa S. Bhat
Date: Mon Jun 24 2019 - 16:16:10 EST


On 6/24/19 12:40 PM, Paolo Valente wrote:
> Hi Jens,
> this series, based against for-5.3/block, contains:
> 1) The improvements to recover the throughput loss reported by
> Srivatsa [1] (first five patches)
> 2) A preemption improvement to reduce I/O latency
> 3) A fix of a subtle bug causing loss of control over I/O bandwidths
>

Thanks a lot for these patches, Paolo!

Would you mind adding:

Reported-by: Srivatsa S. Bhat (VMware) <srivatsa@xxxxxxxxxxxxx>
Tested-by: Srivatsa S. Bhat (VMware) <srivatsa@xxxxxxxxxxxxx>

to the first 5 patches, as appropriate?

Thank you!

>
> [1] https://lkml.org/lkml/2019/5/17/755
>
> Paolo Valente (7):
> block, bfq: reset inject limit when think-time state changes
> block, bfq: fix rq_in_driver check in bfq_update_inject_limit
> block, bfq: update base request service times when possible
> block, bfq: bring forward seek&think time update
> block, bfq: detect wakers and unconditionally inject their I/O
> block, bfq: preempt lower-weight or lower-priority queues
> block, bfq: re-schedule empty queues if they deserve I/O plugging
>
> block/bfq-iosched.c | 952 ++++++++++++++++++++++++++++++--------------
> block/bfq-iosched.h | 25 +-
> 2 files changed, 686 insertions(+), 291 deletions(-)
>

Regards,
Srivatsa
VMware Photon OS