Re: [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT

[Ley Foon Tan]

On Sun, 2019-06-23 at 23:13 +0900, Masahiro Yamada wrote:
> On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> > 
> > 
> > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice
> > with different values, which is pointless and confusing.
> > 
> > [1] arch/nios2/Kconfig
> > 
> > Â config TRACE_IRQFLAGS_SUPPORT
> > ÂÂÂÂÂÂÂÂÂÂdef_bool n
> > 
> > [2] arch/nios2/Kconfig.debug
> > 
> > Â config TRACE_IRQFLAGS_SUPPORT
> > ÂÂÂÂÂÂÂÂÂÂdef_bool y
> > 
> > [1] is included before [2]. In the Kconfig syntax, the first one
> > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'.
> > 
> > The second define in arch/nios2/Kconfig.debug is dead code.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > ---
> Ping.
> 
> 
Acked-by: Ley Foon Tan <ley.foon.tan@xxxxxxxxx>
Will integrate to next kernel version.
Thanks.

> > 
> > Âarch/nios2/Kconfig.debug | 3 ---
> > Â1 file changed, 3 deletions(-)
> > 
> > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
> > index f1da8a7..a8bc06e 100644
> > --- a/arch/nios2/Kconfig.debug
> > +++ b/arch/nios2/Kconfig.debug
> > @@ -1,8 +1,5 @@
> > Â# SPDX-License-Identifier: GPL-2.0
> > 
> > -config TRACE_IRQFLAGS_SUPPORT
> > -ÂÂÂÂÂÂÂdef_bool y
> > -
> > Âconfig EARLY_PRINTK
> > ÂÂÂÂÂÂÂÂbool "Activate early kernel debugging"
> > ÂÂÂÂÂÂÂÂdefault y
> > --
> > 2.7.4
> > 
> 
> --
> Best Regards
> Masahiro Yamada
> 
> ________________________________

Regards
Ley Foon