RE: stmmac regression on ASUS TinkerBoard

From: Jose Abreu
Date: Tue Jun 25 2019 - 03:46:21 EST


From: Katsuhiro Suzuki <katsuhiro@xxxxxxxxxxxxx>

> I checked drivers/net/ethernet/stmicro/stmmac/stmmac_main.c and found
> stmmac_init_phy() is going to fail if ethernet device node does not
> have following property:
> - phy-handle
> - phy
> - phy-device
>
> This commit broke the device-trees such as TinkerBoard. The mdio
> subnode creating a mdio bus is changed to required or still optional?

Yeah, with PHYLINK the PHY binding is always required ...

How do you want to proceed ? I think DT bindings can never break between
releases so I will probably need to cook a patch for stmmac.

Thanks,
Jose Miguel Abreu