Re: [PATCH 0/2] pinctl: armada-37xx: fix for pins 32+
From: Gregory CLEMENT
Date: Tue Jun 25 2019 - 09:39:11 EST
> On Tue, Jun 18, 2019 at 6:01 PM <alpawi@xxxxxxxxxx> wrote:
>> From: Patrick Williams <alpawi@xxxxxxxxxx>
>> The 37xx GPIO config registers are only 32 bits long and
>> span 2 registers for the NB GPIO controller. The function
>> to calculate the offset was missing the increase to the
>> config register.
>> I have tested both raw gpio access and interrupts using
>> libgpiod utilities on an Espressonbin.
>> The first patch is a simple rename of a function because
>> the original name implied it was doing IO itself ("update
>> reg"). This patch could be dropped if undesired.
>> The second patch contains the fix for GPIOs 32+.
First you can add my
Acked-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
Then as the second patch is a fix, you should add the fix tag: "Fixes:
5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the
'CC: <stable@xxxxxxxxxxxxxxx>" tags.
But your change in the first patch made this second patch more difficult
Actually, when I wrote "_update_reg" I was thinking to the update of the
variable, whereas with a function named "_calculate_reg" I am expecting
having the result as a return of the function.
However I am not against your change, as I pointed my main concern is
about the backport of the patch to the stable branch.
Maybe you could change the order of those 2 patches?
> This looks good overall. I am waiting for a maintainer review.
> If nothing happens in a week, poke me and I'll just apply
> the patches.
> Linus Walleij
> linux-arm-kernel mailing list
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering