Re: [PATCH] pinctrl: qcom: sdm845: Fix CONFIG preprocessor guard

From: Linus Walleij
Date: Tue Jun 25 2019 - 10:07:46 EST


On Fri, Jun 21, 2019 at 10:21 PM Nathan Chancellor
<natechancellor@xxxxxxxxx> wrote:

> Clang warns when CONFIG_ACPI is unset:
>
> drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is
> not defined, evaluates to 0 [-Wundef]
> #if CONFIG_ACPI
> ^
> 1 warning generated.
>
> Use ifdef instead of if to resolve this.
>
> Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support")
> Link: https://github.com/ClangBuiltLinux/linux/issues/569
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

Patch applied with the ACKs.
I'm sure Bjorn doesn't mind.

Yours,
Linus Walleij