Re: [PATCH] arm64: dts: imx8mq: Init rates and parents configs for clocks

[Leonard Crestez]

On 25.06.2019 15:51, Abel Vesa wrote:
> Add the initial configuration for clocks that need default parent and rate
> setting. This is based on the vendor tree clock provider parents and rates
> configuration except this is doing the setup in dts rather then using clock
> consumer API in a clock provider driver.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> ---
>   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 34 +++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d09b808..e0abe02 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -489,6 +489,40 @@

> +					<&clk IMX8MQ_CLK_PCIE1_CTRL>,
> +					<&clk IMX8MQ_CLK_PCIE1_PHY>,
> +					<&clk IMX8MQ_CLK_PCIE2_CTRL>,
> +					<&clk IMX8MQ_CLK_PCIE2_PHY>,
> +					<&clk IMX8MQ_CLK_CSI1_CORE>,
> +					<&clk IMX8MQ_CLK_CSI1_PHY_REF>,
> +					<&clk IMX8MQ_CLK_CSI1_ESC>,
> +					<&clk IMX8MQ_CLK_CSI2_CORE>,
> +					<&clk IMX8MQ_CLK_CSI2_PHY_REF>,
> +					<&clk IMX8MQ_CLK_CSI2_ESC>;

This stuff (and NAND) looks like it would belong to device nodes instead.

The rest seem fine though I'm not sure why exactly those clks are 
adjusted in vendor tree.

--
Regards,
Leonard