Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs
From: Gustavo A. R. Silva
Date: Tue Jun 25 2019 - 13:06:22 EST
On 6/25/19 11:52 AM, Joe Perches wrote:
> On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
> []
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>
> Just enable the thing already.
>
> If you stopped trying to do it all yourself, others
What are you talking about?
Anyone can enable it, I'm adding this to every commit:
Warning level 3 was used: -Wimplicit-fallthrough=3
And I'll send a PR with a proper patch for the Makefile
during the next merge window.
If had the power I would have enabled this option since day 1,
so every developer can take care of their own code.
Lately, you are not being of much help, Joe.
--
Gustavo