Re: [PATCH v1 3/6] mm: Use zone and order instead of free area in free_list manipulators

From: Dave Hansen
Date: Tue Jun 25 2019 - 14:36:05 EST


On 6/19/19 3:33 PM, Alexander Duyck wrote:
> - move_to_free_area(page, &zone->free_area[order], migratetype);
> + move_to_free_area(page, zone, order, migratetype);

This certainly looks nicer. But the naming is a bit goofy now because
you're talking about free areas, but there's no free area to be seen.
If anything, isn't it moving to a free_list[]? It's actually going to
zone->free_area[]->free_list[], so the free area seems rather
inconsequential in the entire thing. The (zone/order/migratetype)
combination specifies a free_list[] not a free area anyway.