Re: [PATCH v6 1/2] fTPM: firmware TPM running in TEE

[Randy Dunlap]

Hi,

On 6/25/19 12:52 PM, Sasha Levin wrote:
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 88a3c06fc153..facee3bb5607 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -164,6 +164,11 @@ config TCG_VTPM_PROXY
>  	  /dev/vtpmX and a server-side file descriptor on which the vTPM
>  	  can receive commands.
>  
> +config TCG_FTPM_TEE
> +	tristate "TEE based fTPM Interface"
> +	depends on TEE && OPTEE
> +	---help---
> +	  This driver proxies for fTPM running in TEE

acronym overload.  For the help text, I would at least s/fTPM/firmware TPM/.
Also, end that sentence with a '.'.

>  
>  source "drivers/char/tpm/st33zp24/Kconfig"
>  endif # TCG_TPM


-- 
~Randy