Re: [PATCH v7 0/4] THP aware uprobe

From: Song Liu
Date: Tue Jun 25 2019 - 20:05:31 EST


Hi Oleg,

> On Jun 25, 2019, at 4:53 PM, Song Liu <songliubraving@xxxxxx> wrote:
>
> This set makes uprobe aware of THPs.
>
> Currently, when uprobe is attached to text on THP, the page is split by
> FOLL_SPLIT. As a result, uprobe eliminates the performance benefit of THP.
>
> This set makes uprobe THP-aware. Instead of FOLL_SPLIT, we introduces
> FOLL_SPLIT_PMD, which only split PMD for uprobe.
>
> TODO (temporarily removed in v7):
> After all uprobes within the THP are removed, regroup the PTE-mapped pages
> into huge PMD.
>
> This set (plus a few THP patches) is also available at
>
> https://github.com/liu-song-6/linux/tree/uprobe-thp
>

Do you have further comments/suggestions on this work? If not, could you
please add your Acked-by or Reviewed-by?

Thanks,
Song