Re: [PATCH 4.19 55/90] drm/arm/mali-dp: Add a loop around the second set CVAL and try 5 times

[Pavel Machek]

On Mon 2019-06-24 17:56:45, Greg Kroah-Hartman wrote:
> [ Upstream commit 6a88e0c14813d00f8520d0e16cd4136c6cf8b4d4 ]
> 
> This patch trying to fix monitor freeze issue caused by drm error
> 'flip_done timed out' on LS1028A platform. this set try is make a loop
> around the second setting CVAL and try like 5 times before giveing up.


> @@ -204,8 +205,18 @@ static void malidp_atomic_commit_hw_done(struct drm_atomic_state *state)
>  			drm_crtc_vblank_get(&malidp->crtc);
>  
>  		/* only set config_valid if the CRTC is enabled */
> -		if (malidp_set_and_wait_config_valid(drm) < 0)
> +		if (malidp_set_and_wait_config_valid(drm) < 0) {
> +			/*
> +			 * make a loop around the second CVAL setting and
> +			 * try 5 times before giving up.
> +			 */
> +			while (loop--) {
> +				if (!malidp_set_and_wait_config_valid(drm))
> +					break;
> +			}
>  			DRM_DEBUG_DRIVER("timed out waiting for updated configuration\n");
> +		}
> +

We'll still get the debug message even if
malidp_set_and_wait_config_valid() suceeded. That does not sound
right.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature