Re: [PATCH v3] arm64: rename dump_instr as dump_kernel_instr

From: Will Deacon
Date: Wed Jun 26 2019 - 08:21:44 EST


On Wed, Jun 26, 2019 at 08:50:13PM +0900, jinho lim wrote:
> In traps.c, only __die calls dump_instr.
> However, this function has sub-function as __dump_instr.
>
> dump_kernel_instr can replace those functions.
> By using aarch64_insn_read, it does not have to change fs to KERNEL_DS.
>
> Signed-off-by: jinho lim <jordan.lim@xxxxxxxxxxx>
> ---
> arch/arm64/kernel/traps.c | 23 +++++++----------------
> 1 file changed, 7 insertions(+), 16 deletions(-)

Thanks, this looks good to me now:

Acked-by: Will Deacon <will.deacon@xxxxxxx>

Catalin can pick this up for 5.3.

Will