Re: [PATCH 5/9] x86/mm/tlb: Optimize local TLB flushes

From: Andy Lutomirski
Date: Wed Jun 26 2019 - 12:33:47 EST


On Tue, Jun 25, 2019 at 2:36 PM Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
>
> On 6/12/19 11:48 PM, Nadav Amit wrote:
> > While the updated smp infrastructure is capable of running a function on
> > a single local core, it is not optimized for this case.
>
> OK, so flush_tlb_multi() is optimized for flushing local+remote at the
> same time and is also (near?) the most optimal way to flush remote-only.
> But, it's not as optimized at doing local-only flushes. But,
> flush_tlb_on_cpus() *is* optimized for local-only flushes.

Can we stick the optimization into flush_tlb_multi() in the interest
of keeping this stuff readable?

Also, would this series be easier to understand if there was a patch
to just remove the UV optimization before making other changes?

--Andy