Re: [patch 28/29] x86/hpet: Use common init for legacy clockevent

[Ingo Molnar]

* Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> +static void __init hpet_legacy_clockevent_register(struct hpet_channel *hc)
> +{
> +	/*
> +	 * Start HPET with the boot CPU's cpumask and make it global after
> +	 * the IO_APIC has been initialized.
> +	 */
> +	hc->cpu = boot_cpu_data.cpu_index;
> +	strncpy(hc->name, "hpet", sizeof(hc->name));
> +	hpet_init_clockevent(hc, 50);
> +
> +	hc->evt.tick_resume	= hpet_clkevt_legacy_resume;
> +
> +	/*
> +	 * Legacy horrors and sins from the past. HPET used periodic mode
> +	 * unconditionally for ever on the legacy channel 0. Removing the

s/for ever
 /forever

With that typo fixed:

Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

	Ingo