Re: [PATCH v7 2/2] fTPM: add documentation for ftpm driver

[Sasha Levin]

On Thu, Jun 27, 2019 at 02:34:06AM +0300, Jarkko Sakkinen wrote:
> On Tue, 2019-06-25 at 16:13 -0400, Sasha Levin wrote:
> > This patch adds basic documentation to describe the new fTPM driver.
> >
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  Documentation/security/tpm/index.rst        |  1 +
> >  Documentation/security/tpm/tpm_ftpm_tee.rst | 31 +++++++++++++++++++++
> >  2 files changed, 32 insertions(+)
> >  create mode 100644 Documentation/security/tpm/tpm_ftpm_tee.rst
> >
> > diff --git a/Documentation/security/tpm/index.rst
> > b/Documentation/security/tpm/index.rst
> > index af77a7bbb070..15783668644f 100644
> > --- a/Documentation/security/tpm/index.rst
> > +++ b/Documentation/security/tpm/index.rst
> > @@ -4,4 +4,5 @@ Trusted Platform Module documentation
> >
> >  .. toctree::
> >
> > +   tpm_ftpm_tee
> >     tpm_vtpm_proxy
> > diff --git a/Documentation/security/tpm/tpm_ftpm_tee.rst
> > b/Documentation/security/tpm/tpm_ftpm_tee.rst
> > new file mode 100644
> > index 000000000000..48de0dcec0f6
> > --- /dev/null
> > +++ b/Documentation/security/tpm/tpm_ftpm_tee.rst
> > @@ -0,0 +1,31 @@
> > +=============================================
> > +Firmware TPM Driver
> > +=============================================
> > +
> > +| Authors:
> > +| Thirupathaiah Annapureddy <thiruan@xxxxxxxxxxxxx>
> > +| Sasha Levin <sashal@xxxxxxxxxx>
>
> The way I see it this thing should not exist here at all but the
> first patch should have co-developed-by in addition to
> signed-off-by from you. Otherwise looks good. The list of authors
> is againt something that Git does better than humans.

I've dropped this part, but left the co-developed tag out, I honestly
don't think that I had significant contribution here.

--
Thanks,
Sasha