Re: [PATCH v2] jffs2: remove C++ style comments from uapi header
From: Richard Weinberger
Date: Thu Jun 27 2019 - 03:39:11 EST
----- UrsprÃngliche Mail -----
> Von: "Masahiro Yamada" <yamada.masahiro@xxxxxxxxxxxxx>
> An: "richard" <richard@xxxxxx>
> CC: "Vignesh Raghavendra" <vigneshr@xxxxxx>, "Boris Brezillon" <bbrezillon@xxxxxxxxxx>, "linux-kernel"
> <linux-kernel@xxxxxxxxxxxxxxx>, "Marek Vasut" <marek.vasut@xxxxxxxxx>, "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>,
> "Miquel Raynal" <miquel.raynal@xxxxxxxxxxx>, "Brian Norris" <computersforpeace@xxxxxxxxx>, "David Woodhouse"
> <dwmw2@xxxxxxxxxxxxx>
> Gesendet: Donnerstag, 27. Juni 2019 09:06:31
> Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header
> On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@xxxxxx> wrote:
>>
>> ----- UrsprÃngliche Mail -----
>> > Von: "Masahiro Yamada" <yamada.masahiro@xxxxxxxxxxxxx>
>> > An: "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>
>> > CC: "Boris Brezillon" <bbrezillon@xxxxxxxxxx>, "Miquel Raynal"
>> > <miquel.raynal@xxxxxxxxxxx>, "Brian Norris"
>> > <computersforpeace@xxxxxxxxx>, "Vignesh Raghavendra" <vigneshr@xxxxxx>, "Marek
>> > Vasut" <marek.vasut@xxxxxxxxx>,
>> > "Masahiro Yamada" <yamada.masahiro@xxxxxxxxxxxxx>, "richard" <richard@xxxxxx>,
>> > "David Woodhouse" <dwmw2@xxxxxxxxxxxxx>,
>> > "linux-kernel" <linux-kernel@xxxxxxxxxxxxxxx>
>> > Gesendet: Dienstag, 18. Juni 2019 05:09:26
>> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header
>>
>> > Linux kernel tolerates C++ style comments these days. Actually, the
>> > SPDX License tags for .c files start with //.
>> >
>> > On the other hand, uapi headers are written in more strict C, where
>> > the C++ comment style is forbidden.
>> >
>> > I simply dropped these lines instead of fixing the comment style.
>> >
>> > This code has been always commented out since it was added around
>> > Linux 2.4.9 (i.e. commented out for more than 17 years).
>> >
>> > 'Maybe later...' will never happen.
>>
>> :-)
>>
>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>
>> Acked-by: Richard Weinberger <richard@xxxxxx>
>>
>> Thanks,
>> //richard
>
>
> Will this be picked up for v5.3-rc1 ?
Yes.
Thanks,
//richard