Re: [PATCH v7 2/6] i2c: acpi: Use available IRQ helper functions

From: Charles Keepax
Date: Thu Jun 27 2019 - 04:19:04 EST


On Wed, Jun 26, 2019 at 10:09:06PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 26, 2019 at 04:02:58PM +0100, Charles Keepax wrote:
> > Use the available IRQ helper functions, most of the functions have
> > additional helpful side affects like configuring the trigger type of the
> > IRQ.
>
> > - acpi_dev_free_resource_list(&resource_list);
>
> I have thought that we can drop completely the resource_list, though ACPI
> doesn't allow this. So, I would rather withdraw this change to be on the safe
> (symmetrical) side.
>

Yeah would be my preference as well, will do another spin.

Thanks,
Charles