Re: [RFC PATCH v3 1/4] vfio: Define device specific irq type capability
From: Gerd Hoffmann
Date: Thu Jun 27 2019 - 06:20:52 EST
On Thu, Jun 27, 2019 at 08:55:21AM +0000, Zhang, Tina wrote:
>
>
> > -----Original Message-----
> > From: intel-gvt-dev [mailto:intel-gvt-dev-bounces@xxxxxxxxxxxxxxxxxxxxx] On
> > Behalf Of Gerd Hoffmann
> > Sent: Thursday, June 27, 2019 2:20 PM
> > To: Zhang, Tina <tina.zhang@xxxxxxxxx>
> > Cc: Tian, Kevin <kevin.tian@xxxxxxxxx>; kvm@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; zhenyuw@xxxxxxxxxxxxxxx; Yuan, Hang
> > <hang.yuan@xxxxxxxxx>; alex.williamson@xxxxxxxxxx; Lv, Zhiyuan
> > <zhiyuan.lv@xxxxxxxxx>; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx; Wang, Zhi A
> > <zhi.a.wang@xxxxxxxxx>
> > Subject: Re: [RFC PATCH v3 1/4] vfio: Define device specific irq type
> > capability
> >
> > Hi,
> >
> > > +struct vfio_irq_info_cap_type {
> > > + struct vfio_info_cap_header header;
> > > + __u32 type; /* global per bus driver */
> > > + __u32 subtype; /* type specific */
> >
> > Do we really need both type and subtype?
> Then, if one device has several irqs, how can we identify them?
> Thanks.
Just assign multiple types?
cheers,
Gerd