Re: [PATCH v2 2/7] x86/ftrace: Fix use of flags in ftrace_replace_code()

[Naveen N. Rao]

Steven Rostedt wrote:
> On Thu, 27 Jun 2019 16:53:50 +0530
> "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:
>
> > In commit a0572f687fb3c ("ftrace: Allow ftrace_replace_code() to be
> > schedulable), the generic ftrace_replace_code() function was modified to
> > accept a flags argument in place of a single 'enable' flag. However, the
> > x86 version of this function was not updated. Fix the same.
> >
> > Fixes: a0572f687fb3c ("ftrace: Allow ftrace_replace_code() to be schedulable")
>
> I don't mind this change, but it's not a bug, and I'm not sure it
> should have the fixes tag. The reason being, the
> FTRACE_MODIFY_ENABLE_FL is only set when ftrace is called by with the
> command flag FTRACE_MAY_SLEEP, which is never done on x86.

I guess you meant to say that *FTRACE_MODIFY_MAY_SLEEP_FL* is only set 
with FTRACE_MAY_SLEEP.

> That said, I'm fine with the change as it makes it more robust, but by
> adding the fixes tag, you're going to get this into all the stable
> code, and I'm not sure that's really necessary.

Agreed. Thanks for pointing this out. We can drop this patch from this 
series and I will re-post this as a simpler cleanup later on.


Thanks,
Naveen