Re: linux-next: Tree for Jun 26 (security/integrity/ima/)

[Randy Dunlap]

On 6/27/19 6:29 AM, David Howells wrote:
> Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote:
> 
>>>   CC      security/integrity/ima/ima_fs.o
>>> In file included from ../security/integrity/ima/ima.h:25:0,
>>>                  from ../security/integrity/ima/ima_fs.c:26:
>>> ../security/integrity/ima/../integrity.h:170:18: warning: âstruct key_aclâ declared inside parameter list [enabled by default]
>>>            struct key_acl *acl)
>>>                   ^
>>> ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>
>> David, CONFIG_INTEGRITY_SIGNATURE is dependent on KEYS being enabled,
>> but the stub functions are not. ÂThere's now a dependency on
>> key_acl().
> 
> I added a forward declaration for struct key_acl into
> security/integrity/integrity.h as you can see here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/diff/security/integrity/integrity.h?h=keys-acl&id=75ce113a1d56880e5abd37fa664ea9af399d2bcd
> 
> which might not have made it into linux-next before you used it.

No problem in linux-next 20190627.

Thanks.

-- 
~Randy